frontend: Enable cluster deletion in browser by alokdangre · Pull Request #4461 · kubernetes-sigs/headlamp

alokdangre · 2026-01-27T06:32:38Z

Summary

This change enables the deletion of clusters when running Headlamp in a browser, provided that dynamic cluster management is enabled in the backend configuration.

Previously, cluster deletion was restricted to the Electron app.

Related Issue

Fixes #3053

Changes

Adds isDynamicClusterEnabled to the Redux config state.
Updates ClusterContextMenu to check this flag in addition to isElectron.
Ensures the X-HEADLAMP_BACKEND-TOKEN is set correctly in development mode for API requests.

Steps to Test

Go to view cluster
click on three dots
click delete
confirm

Screenshots (if applicable)

Screen.Recording.2026-01-27.114635.mp4

alokdangre · 2026-01-27T10:54:52Z

@illume ptal

Copilot

Pull request overview

This PR enables cluster deletion in browser mode when dynamic cluster management is enabled in the backend configuration. Previously, cluster deletion was restricted to the Electron desktop app only.

Changes:

Added isDynamicClusterEnabled flag to Redux config state to track backend dynamic cluster support
Updated ClusterContextMenu to show delete option when either running in Electron or when dynamic clusters are enabled
Modified backend token initialization to support development scenarios via environment variable

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
frontend/src/redux/configSlice.ts	Adds isDynamicClusterEnabled field to ConfigState and updates setConfig reducer to handle the new optional parameter
frontend/src/redux/configSlice.test.ts	Adds test case to verify setConfig properly handles isDynamicClusterEnabled parameter
frontend/src/helpers/getHeadlampAPIHeaders.ts	Initializes backendToken from REACT_APP_HEADLAMP_BACKEND_TOKEN environment variable for development scenarios
frontend/src/components/App/Home/ClusterContextMenu.tsx	Updates cluster delete menu item visibility logic to check isDynamicClusterEnabled in addition to isElectron()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/redux/configSlice.test.ts

frontend/src/helpers/getHeadlampAPIHeaders.ts

illume

Thanks for this.

I see this issue in the filing GitHub check:

src/components/project/ProjectCreateFromYaml.stories.tsx:35:7 - error TS2741: Property 'isDynamicClusterEnabled' is missing in type '{ clusters: null; statelessClusters: null; allClusters: any; settings: { tableRowsPerPageOptions: number[]; timezone: string; useEvict: true; }; }' but required in type 'ConfigState'.

35       config: {
         ~~~~~~

  src/redux/configSlice.ts:49:3
    49   isDynamicClusterEnabled: boolean;
         ~~~~~~~~~~~~~~~~~~~~~~~
    'isDynamicClusterEnabled' is declared here.

[error] Found 1 errors and 2 warnings

Please also consider the open comments?

alokdangre · 2026-01-30T15:21:57Z

@illume fixed the changes ptal

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/helpers/getHeadlampAPIHeaders.ts

frontend/src/components/App/Home/ClusterContextMenu.tsx

joaquimrocha

I am not sure we should make this dependent on the dynamic clusters being available because the dynamic clusters don't have much to do with being able to delete a cluster from the kubeconfig.
Still we should make sure that we do not offer this option (and especially that we do not effectively remove clusters) when Headlamp has been deployed with kubeconfig as an option. We need to be extremely cautious with this, as we don't want users removing clusters from their company-deployed Headlamp.

So maybe this means we should have a flag --allow-kubeconfig-removal or something, which would be false by default, but we'd set it to true when developing and when running the app (which would work in headless mode).

@sniok / @illume , WDYT?

BTW, there was already this PR in draft from last year: #3339

alokdangre · 2026-02-10T08:16:33Z

I am not sure we should make this dependent on the dynamic clusters being available because the dynamic clusters don't have much to do with being able to delete a cluster from the kubeconfig. Still we should make sure that we do not offer this option (and especially that we do not effectively remove clusters) when Headlamp has been deployed with kubeconfig as an option. We need to be extremely cautious with this, as we don't want users removing clusters from their company-deployed Headlamp.

So maybe this means we should have a flag --allow-kubeconfig-removal or something, which would be false by default, but we'd set it to true when developing and when running the app (which would work in headless mode).

@sniok / @illume , WDYT?

BTW, there was already this PR in draft from last year: #3339

that's very nice point, it seems good to me, im implementing the suggested review
also the draft pr was stale from long time, and also the issue was unassigned from that user so i took the issue

joaquimrocha · 2026-02-11T12:14:27Z

Changes look good. I was gonna suggest we use ALLOW_KUBECONFIG_CHANGES as the removal alone is too broad, but then I double checked how we are allowing adding new clusters to the kubeconfig just on the condition we are running in Electron, and now I am having doubts if we need a new flag or we just use isElectron.
I think in the past we refrained from removing clusters from the kubeconfig as this could surprise the user, but as Headlamp has become more established, I wonder if we have enough support that it's a major Kubernetes UI and thus it's expected that it changes the kubeconfig.

So to be clear: either we add a new "AllowKubeConfigChanges" flag, or we do not any new flags and allow deleting clusters from the kubeconfig files only when isElectron() is true.

Any thoughts @sniok / @illume ?

sniok · 2026-02-11T17:27:39Z

or we do not any new flags and allow deleting clusters from the kubeconfig files only when isElectron() is true.

doesn't it already work like this? we can delete clusters in the app

alokdangre · 2026-02-12T06:16:58Z

or we do not any new flags and allow deleting clusters from the kubeconfig files only when isElectron() is true.

doesn't it already work like this? we can delete clusters in the app

yes its the logic currently used in app, but i added a flag in this pr, so i will remove the flag from the electron app

illume

Thanks for making those changes. It got me thinking about something else...

Can we enable this flag by default in "headless" mode? See the app/electron/main.ts for headless mode.

Since this is a local thing, if we can enable this functionality for headless mode it will more closely match the abilities of the app. Since the security context of these two modes are pretty much the same... they are both app mode run by an individual.

alokdangre · 2026-02-12T15:07:15Z

Thanks for making those changes. It got me thinking about something else...

Can we enable this flag by default in "headless" mode? See the app/electron/main.ts for headless mode.

Since this is a local thing, if we can enable this functionality for headless mode it will more closely match the abilities of the app. Since the security context of these two modes are pretty much the same... they are both app mode run by an individual.

done

illume

Thanks! 🎉

(I’ll leave this one open to give the others a chance to have a look)

k8s-ci-robot · 2026-02-12T15:42:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alokdangre, illume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [illume]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Enable cluster deletion when running in a browser if dynamic cluster management is enabled in the backend. This was previously restricted to the Electron app.

Introduces a new backend configuration flag --allow-kubeconfig-removal to control whether users can delete clusters sourced from their kubeconfig via the UI. - backend: Add flag and expose it in client config. - frontend: Conditionally enable delete option based on flag. - electron: Enable flag in headless mode (shared security context). - makefile: Enable flag in dev mode.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2026

k8s-ci-robot requested review from ashu8912 and joaquimrocha January 27, 2026 06:32

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2026

illume requested a review from Copilot January 28, 2026 18:30

Copilot started reviewing on behalf of illume January 28, 2026 18:30 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

frontend/src/redux/configSlice.test.ts Show resolved Hide resolved

frontend/src/helpers/getHeadlampAPIHeaders.ts Show resolved Hide resolved

illume requested changes Jan 28, 2026

View reviewed changes

alokdangre force-pushed the feature/allow-cluster-deletion-in-browser branch from da1ade9 to 9777483 Compare January 30, 2026 15:21

alokdangre requested a review from illume January 30, 2026 15:22

illume requested a review from Copilot January 30, 2026 15:28

Copilot started reviewing on behalf of illume January 30, 2026 15:28 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

frontend/src/helpers/getHeadlampAPIHeaders.ts Show resolved Hide resolved

illume reviewed Jan 30, 2026

View reviewed changes

frontend/src/components/App/Home/ClusterContextMenu.tsx Show resolved Hide resolved

alokdangre requested a review from illume January 30, 2026 16:41

joaquimrocha reviewed Feb 3, 2026

View reviewed changes

alokdangre force-pushed the feature/allow-cluster-deletion-in-browser branch from 9777483 to 71c1809 Compare February 10, 2026 13:04

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2026

alokdangre force-pushed the feature/allow-cluster-deletion-in-browser branch from 71c1809 to 3ec736e Compare February 10, 2026 13:20

alokdangre requested a review from joaquimrocha February 10, 2026 15:13

alokdangre force-pushed the feature/allow-cluster-deletion-in-browser branch from 3ec736e to 7e55baf Compare February 12, 2026 11:19

illume requested changes Feb 12, 2026

View reviewed changes

alokdangre force-pushed the feature/allow-cluster-deletion-in-browser branch from 7e55baf to aeaed7e Compare February 12, 2026 12:46

alokdangre requested a review from illume February 12, 2026 15:07

illume approved these changes Feb 12, 2026

View reviewed changes

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 12, 2026

alokdangre added 2 commits February 14, 2026 06:10

frontend: Enable cluster deletion in browser

2c56c90

Enable cluster deletion when running in a browser if dynamic cluster management is enabled in the backend. This was previously restricted to the Electron app.

alokdangre force-pushed the feature/allow-cluster-deletion-in-browser branch from aeaed7e to 2c04685 Compare February 14, 2026 06:17

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2026

illume added the frontend Issues related to the frontend label Feb 14, 2026

illume added this to the v0.41.0 milestone Feb 14, 2026

Conversation

alokdangre commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Changes

Steps to Test

Screenshots (if applicable)

Uh oh!

alokdangre commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

alokdangre commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

joaquimrocha left a comment

Choose a reason for hiding this comment

Uh oh!

alokdangre commented Feb 10, 2026

Uh oh!

joaquimrocha commented Feb 11, 2026

Uh oh!

sniok commented Feb 11, 2026

Uh oh!

alokdangre commented Feb 12, 2026

Uh oh!

illume left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alokdangre commented Feb 12, 2026

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alokdangre commented Jan 27, 2026 •

edited

Loading

illume left a comment •

edited

Loading